ServiceInfo now gets the provided interfaces from the .serviceconfig #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
bkeryan
requested changes
May 22, 2023
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
bkeryan
requested changes
May 22, 2023
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
bkeryan
approved these changes
May 23, 2023
DelpireNI
deleted the
users/cdelpire/read-provided-interfaces-from-serviceconfig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Rather than hard coding the provided interfaces, these will now be determined by the
.serviceconfigfile.Why should this Pull Request be merged?
Currently when a measurement service is registered, it will have both the v1 and v2 provided interfaces. You should be able to specify which interfaces you provide
What testing has been done?
Tested manually to ensure the correct provided interfaces are being registered with the discovery service based on the
.serviceconfigfile.MeasurementService'sServiceInfois populated by the.serviceconfigfile.